Deduplicate columns to select in add_keep_cols
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek Mahajan <[email protected]>
VibhuJawa
approved these changes
Sep 25, 2024
Co-authored-by: Vibhu Jawa <[email protected]>
Signed-off-by: Praateek Mahajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cudf 24.10 we can't allow duplicate columns to be selected see https://github.com/rapidsai/cudf/pull/16514/files
In our
Op.add_keep_colswe addlist(dict.from_keys(...))to ensure we deduplicate the columns. Originally while we were adding columns to output in the for loop, we were then concatenating the listskeep_cols+output.columns(which already had the keep_cols because of the for loop above) which resulted in duplicates